Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control plane robustness #10625

Open
lgadban opened this issue Feb 13, 2025 · 2 comments
Open

control plane robustness #10625

lgadban opened this issue Feb 13, 2025 · 2 comments
Milestone
kgw 2nd cut

Comments

@lgadban
Copy link
Contributor

lgadban commented Feb 13, 2025 •
edited
Loading

draft notes:
either block envoy updates on errors, or drop the bad route; either way propagate and log the errors
route replacement / not setting snapshot in the cache if we have errors
@lgadban lgadban converted this from a draft issue Feb 13, 2025
@lgadban lgadban moved this from Backlog to Planned in Kgateway Planning Feb 13, 2025
@lgadban lgadban added this to the kgw 2nd cut milestone Feb 13, 2025
@lgadban lgadban mentioned this issue Feb 13, 2025
Merged
4 tasks
@lgadban
Copy link
Contributor Author

lgadban commented Feb 13, 2025

see also:
#10506 (comment)
#10506 (comment)

@lgadban lgadban changed the title fallibility: either block envoy updates on errors, or drop the bad route; either way propagate and log the errors control plane robustness Feb 13, 2025
@ilrudie
Copy link
Contributor

ilrudie commented Feb 13, 2025

Possibly helpful information for implementer. KRT has ctx.DiscardResult() which allows falling back to the previous "good" state if there is one. Take a peak at pkg/kube/krt/collection.go for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Kgateway Planning
Status: Planned
Milestone
kgw 2nd cut
Development

No branches or pull requests
2 participants
@lgadban @ilrudie