Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change start_date & end_date logic to individual component to match the api #5

Closed
kggx opened this issue May 12, 2024 · 1 comment · Fixed by #4
Closed

Change start_date & end_date logic to individual component to match the api #5

kggx opened this issue May 12, 2024 · 1 comment · Fixed by #4
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kggx
Copy link
Owner

kggx commented May 12, 2024

A date_from, date_end, time_from & time_to parameter can be added to the Exploration-API Query.

  • date_from: Start date in the query
  • date_to: End date in the query
  • time_from: Start time of an event
  • time_to: End time of an event

How ever currently the module expects a point in time for either start_date or end_date and parses automatically date_from and time_from as well as date_to and time_to. This will result in a unexpected results

Proposal is to change the input into individual parameters and mark start_date & end_date as deprecated

Blocks #4

@kggx kggx added bug Something isn't working enhancement New feature or request labels May 12, 2024
@kggx kggx added this to the Open source release milestone May 12, 2024
@kggx kggx self-assigned this May 12, 2024
@kggx kggx linked a pull request May 12, 2024 that will close this issue
3 tasks
@kggx
Copy link
Owner Author

kggx commented May 12, 2024

LGTM

@kggx kggx closed this as completed in #4 May 12, 2024
@kggx kggx closed this as completed in 08f6403 May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant