Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptic error given when running hippunfold before hippunfold_download_models is run #193

Closed
akhanf opened this issue Jun 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@akhanf
Copy link
Member

akhanf commented Jun 7, 2022

The error message is cryptic because of the generic copy_to_results rule, since any missing file for a rule ends up then checking that rule, where is ultimately fails..

I'd like to actually get rid of this generic rule, will make updating the workflow much easier.. was a lazy addition in the first place. I will also add some explicit checks on whether the trained models are downloaded already, and provide a useful warning if any are missing.

@akhanf akhanf added the bug Something isn't working label Jun 7, 2022
@akhanf akhanf self-assigned this Jun 7, 2022
@akhanf
Copy link
Member Author

akhanf commented Jun 7, 2022

By the way, this is the error message:

WorkflowError:
MissingInputException: Missing input files for rule copy_to_results:
    output: hippunfold/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfaces.spec
    wildcards: file=sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfaces.spec
    affected files:
        work/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfaces.spec
WorkflowError:
    MissingInputException: Missing input files for rule copy_to_results:
        output: hippunfold/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_gyrification.shape.gii
        wildcards: file=sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_gyrification.shape.gii
        affected files:
            work/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_gyrification.shape.gii
    WorkflowError:
        MissingInputException: Missing input files for rule copy_to_results:
            output: hippunfold/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfarea.shape.gii
            wildcards: file=sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfarea.shape.gii
            affected files:
                work/sub-001/surf/sub-001_hemi-L_space-T1w_den-0p5mm_label-hipp_surfarea.shape.gii
        CyclicGraphException: Cyclic dependency on rule warp_gii_to_native.

@akhanf
Copy link
Member Author

akhanf commented Jun 7, 2022

working on this in #194

@akhanf
Copy link
Member Author

akhanf commented Jul 1, 2022

Closed with #194

@akhanf akhanf closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant