Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Log message when no images found #215

Closed
pvandyken opened this issue Dec 14, 2022 · 1 comment · Fixed by #254
Closed

Confusing Log message when no images found #215

pvandyken opened this issue Dec 14, 2022 · 1 comment · Fixed by #254
Labels
bug Something isn't working

Comments

@pvandyken
Copy link
Contributor

Got the following log message in my snakemake workflow:

No images found for participants

First, there's no indication this is a snakebids warning (to reiterate discussion in #184). If I wasn't a snakebids dev I doubt it would be obvious what had triggered the warning.

Second, I had to check the source code to realize that this was referring to the component I had, wisely or otherwise, called 'participants'. The remedy here is to add a lot more context to the error; something like:

No images found for the following components:
	participants:
		filters:
			blah
			blah
			blah
		wildcards:
			blah
			blah
@pvandyken pvandyken added the bug Something isn't working label Dec 14, 2022
@tkkuehn
Copy link
Contributor

tkkuehn commented Dec 16, 2022

I think adding more context here makes a ton of sense at little cost

The line in question: https://github.com/akhanf/snakebids/blob/main/snakebids/core/input_generation.py#L962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants