Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that there lost a parentheses in the compute_hessian function. -- (p-n) / 2.*eps #34

Open
Frizy-up opened this issue Feb 12, 2020 · 1 comment

Comments

@Frizy-up
Copy link

compute_hessian function last line :
hessian = [(p-n) / 2.*eps for p, n in zip(dalpha_pos, dalpha_neg)] should be changed to:
hessian = [(p-n) / (2.*eps) for p, n in zip(dalpha_pos, dalpha_neg)] according to the paper equation 8.

@jkooy
Copy link

jkooy commented Jul 22, 2020

I didn't find this at the beginning and have tried both these two. This indeed affects the update step but luckily not much on the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants