Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not restore notifications after phone reboot and even after starting app #21

Open
p5n opened this issue Jul 10, 2017 · 7 comments
Open

Comments

@p5n
Copy link

p5n commented Jul 10, 2017

Does not restore notifications after phone reboot and even after starting app. It is needed tap off/on to put them back to notification bar.

(Android 4.0.4)

@khuttun
Copy link
Owner

khuttun commented Jul 23, 2017

I tested this with Android 6.0.1 phone and with Android 4.0.3 emulator, and restoring of the notes after reboot worked for me in both. Do you have the latest version (1.5) of the app installed?

@p5n
Copy link
Author

p5n commented Jul 24, 2017

Yes, it is 1.5 version.

I can also reproduce it without reboot:

  • add some notes
  • go to app manager and force application stop
  • start it again
  • notification bar still empty however application shows switched on notes

@mesophoniac
Copy link

I have the same "problem". But not after reboot!
I still have a note created and enabled ...

  1. go to app manager and force application stop
  2. start app again
  3. notification bar still empty however application shows switched on notes

@mesophoniac
Copy link

I have added in NotesListAdapter.java on Line 100 setNotification(n);

Original
@OverRide
public void onBindViewHolder(ViewHolder holder, int position)
{
NotificationNote n = this.notes.get(position);
holder.titleView.setText(n.title);
holder.textView.setText(n.text);
holder.switchView.setChecked(n.isVisible);
setNotification(n);
}

After FORCE STOP and starting the APP all the enabled (visible) Notes will show in the notification bar

@p5n
Copy link
Author

p5n commented Jul 25, 2017

I can confirm that "setNotification(n);" fixes this issue.

PS. It fixes for stopping, but does not for reboot. I will test it more.

@khuttun
Copy link
Owner

khuttun commented Jul 26, 2017

onBindViewHolder is related to displaying the notes list within the app, it's not correct place to call the notification triggering code (setNotification).

When you do the force stop, Android warns you that the app "may misbehave". This is what's happening here, Notification Notes misbehaves as it's force stopped.

I believe the original issue with the rebooting is a different one.

@4ut0-M-4t
Copy link

OS/version: Android 6.0.1
NNotes version: 1.5

Missing notifications after reboot.
This kind of behavior seems invariable, rather inconsistent to reproduce with ease. But it still happens (from time to time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants