.rubocop.yml

require:
  - rubocop-rails
  - rubocop/rspec/focused
  - rubocop-rspec
  - rubocop-performance
Style/Documentation:
  Enabled: false
AllCops:
  Exclude:
    - 'Gemfile'
    - 'Guardfile'
    - 'Rakefile'
    - 'db/*'
    - 'db/**/*'
    - 'node_modules/**/*'
    - 'config/**/*'
    - 'bin/**/*'
    - 'vendor/**/*'
    - 'app/views/**/**/*.haml'
    - 'docs/**/*'
    - 'setup/*'
  TargetRubyVersion: 2.5

Layout/LineLength:
  Max: 100

Metrics/ClassLength:
  Max: 127 # We should bring this down, ideally to the default of 100
  Exclude: # These are too big, and should be shrunk if feasible.
    - 'app/models/course.rb'
    - 'app/controllers/surveys_controller.rb'
    - 'app/controllers/campaigns_controller.rb'
    - 'app/controllers/courses_controller.rb'
    - 'lib/importers/revision_score_importer.rb'
    - 'lib/wizard_timeline_manager.rb'
    - 'lib/wiki_course_edits.rb'

Metrics/AbcSize:
  Max: 23 # We should bring this down, ideally to the default of 15
  Exclude:
    - 'spec/**/*' # not a big deal in spec helper methods

Style/NumericPredicate:
  Exclude:
    - 'spec/**/*' # RSpec comparison matchers don't have predicate versions
Metrics/BlockLength:
  Exclude:
    - 'spec/**/*' # pretty much impossible with RSpec
    - 'lib/tasks/*' # also impractical for Rake tasks
    - 'app/views/**/*' # jbuilder requires long blocks for large json views
Metrics/MethodLength:
  Max: 16 # We should bring this down, ideally to the default of 10
  Exclude:
    - 'spec/**/*' # not a big deal in spec helper methods
Metrics/ModuleLength:
  Exclude:
    - 'spec/**/*' # not a big deal in spec helper module
    - 'app/helpers/surveys_helper.rb' # this is too big and should be shrunk


########################
# Recently-added rules #
########################
Style/HashEachMethods:
  Enabled: true
Style/HashTransformKeys:
  Enabled: true
Style/HashTransformValues:
  Enabled: true

########################
# Permanent exceptions #
########################

Layout/SpaceAroundEqualsInParameterDefault:
  Enabled: false
Style/ClassAndModuleChildren:
  Enabled: false
Style/ColonMethodCall:
  Enabled: false
Style/NumericLiterals:
  # We should use underscores when the number is meaningful. But when it's
  # an arbitrary number like a user id, underscores are just clutter.
  Enabled: false
Style/AsciiComments:
  Enabled: false # We need non-ascii characters to document Wikipedia stuff.
Style/ParallelAssignment:
  Enabled: false # We generally use this only to initialize empty variables.
Style/RedundantReturn:
  Enabled: false # Sometimes a redundant return enhances clarity.
Style/SymbolArray:
  Enabled: false # Rare syntax that is potentially confusing to newcomers.
Naming/VariableNumber:
  Enabled: false # Not very helpful, and conflicts with wp10-related names
Rails/Blank:
  Enabled: false # Sometimes unless foo.present? is more expressive.
Layout/EmptyLineAfterMagicComment:
  Enabled: false # These get removed whenever 'annotate' updates a file anyway.
Naming/MethodParameterName:
  Enabled: false # This is too restrictive. Calling errors `e` is fine, for example.
Layout/EmptyLineAfterGuardClause:
  Enabled: false # Not very helpful
Layout/TrailingWhitespace: # To disallow trailing whitespaces
  Enabled: true
Layout/HashAlignment:
  Enabled: false # Hashes look uglier when corrected
  
########################
# Temporary exceptions #
########################

# These should be enabled once violations are fixed,
# or they should be moved to the 'Permanent' section
# if we decide they shouldn't be fixed.

Rails/FilePath:
  Enabled: false
Rails/SkipsModelValidations:
  Enabled: false
Rails/OutputSafety:
  Enabled: false
Performance/UnfreezeString:
  Enabled: false
Style/GuardClause:
  Enabled: false
Rails/HasManyOrHasOneDependent:
  Enabled: false
Rails/InverseOf:
  Enabled: false
Rails/UnknownEnv:
  Enabled: false
Rails/Delegate:
  Enabled: false
Rails/HasAndBelongsToMany:
  Enabled: false
Rails/Validation:
  Enabled: false
Rails/FindBy:
  Enabled: false
Rails/Output:
  Enabled: false
Rails/RakeEnvironment:
  Enabled: false
Naming/MemoizedInstanceVariableName:
  Enabled: false
Rails/ActiveRecordAliases:
  Enabled: false
Style/ExpandPathArguments:
  Enabled: false
Layout/ClosingHeredocIndentation:
  Enabled: false # buggy in 0.57.2: https://github.com/rubocop-hq/rubocop/issues/6009
RSpec/InstanceVariable:
  Enabled: false
RSpec/ExampleLength:
  Enabled: false
RSpec/NamedSubject:
  Enabled: false
RSpec/ContextWording:
  Enabled: false
RSpec/NestedGroups:
  Enabled: false
RSpec/VerifiedDoubles:
  Enabled: false
RSpec/MultipleExpectations:
  Enabled: false
RSpec/BeforeAfterAll:
  Enabled: false
RSpec/EmptyExampleGroup:
  Enabled: false
RSpec/ScatteredLet:
  Enabled: false
RSpec/LetSetup:
  Enabled: false
RSpec/AnyInstance:
  Enabled: false
RSpec/RepeatedDescription:
  Enabled: false
RSpec/MessageSpies:
  Enabled: false
Capybara/CurrentPathExpectation:
  Enabled: false
RSpec/DescribeClass:
  Enabled: false
RSpec/ExpectInHook:
  Enabled: false
RSpec/ScatteredSetup:
  Enabled: false
RSpec/MultipleDescribes:
  Enabled: false
RSpec/ExampleWording:
  Enabled: false
RSpec/Be:
  Enabled: false
Style/DateTime:
  Enabled: false