Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not waiting for an app to finish #14

Closed
FreeHarry opened this issue Oct 25, 2024 · 2 comments · Fixed by #15
Closed

Not waiting for an app to finish #14

FreeHarry opened this issue Oct 25, 2024 · 2 comments · Fixed by #15

Comments

@FreeHarry
Copy link

This is an issue with shim kiennq in scoop 0.5.2
I have WinMerge (GUI) installed with scoop and use the shim WinMergeU.exe in my .gitconfig as difftool:

# Git config
[difftool "winmerge"]
    name = WinMerge
    cmd = "WinMergeU.exe" -u -e -r $LOCAL $REMOTE

When I run, e.g git difftool -d HEAD, then Git is NOT waiting for WinMerge to close the diff and the temp-files generated by git are removed immediately . So diff will not work.

The same happens with Notepad++, set as editor in .gitconfig:

# Git config
[core]
	editor = "notepad++.exe" -multiInst -notabbar -nosession
	autocrlf = input

So when I run e.g. git commit, then Git is NOT waiting for Notepad++ to close.

I have this issue only with shim kiennq. When I use the shim default, I don't have this problem, neither if I use the explicit app-path to WinMerge.

Is this behavior of kiennq intended?

@kiennq
Copy link
Owner

kiennq commented Nov 2, 2024

It was intended before (I can't recall why) but the idea is the Windows app can be detached immediately without waiting for it to finish.
Can you try with this version https://github.com/kiennq/scoop-better-shimexe/releases/tag/v3.1.1.1e9d6fc to see if your issue is resolved?

@kiennq kiennq closed this as completed in #15 Nov 3, 2024
@FreeHarry
Copy link
Author

I checked it and it is working correctly now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants