Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inventory items out of images.json #119

Closed
evktalo opened this issue Sep 22, 2019 · 2 comments
Closed

Refactor inventory items out of images.json #119

evktalo opened this issue Sep 22, 2019 · 2 comments
Milestone

Comments

@evktalo
Copy link
Member

evktalo commented Sep 22, 2019

Inventory items that are added to inventory over the course of adventure are currently defined in images.json, and are added in their own invisible Konva Layer to the stage.

Can we get rid of this extra Layer?

Could we add them to the inventory layer "on the fly" as they are picked up / created to the inventory?

@evktalo
Copy link
Member Author

evktalo commented Sep 28, 2019

Instead of having a layer of their own, could the inventory items (when invisible) reside in the inventory layer?

Is it necessary for them to reside in a layer at all? Can they exist in the stage in some other way?

Could they be created on the fly, instead of at the start?

@evktalo
Copy link
Member Author

evktalo commented Sep 28, 2019

Minimal implementation in 770bae0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant