Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset objectURL memory leak (on import) #28

Open
evktalo opened this issue Feb 15, 2020 · 0 comments
Open

Asset objectURL memory leak (on import) #28

evktalo opened this issue Feb 15, 2020 · 0 comments
Labels
bug Something isn't working internals

Comments

@evktalo
Copy link
Member

evktalo commented Feb 15, 2020

Loaded assets (images/audio) are not released/revoked when importing a new project. This can be easily reproduced by importing large projects multiple times in a single tab and observing the memory usage.

Right now it's not a big (or even noticeable) issue unless the user imports huge projects multiple times within a session.

This can most likely be fixed by revoking each existing objectURL (with window.URL.revokeObjectURL) when importing a project (since they wont be accessible in the UI anymore). It would be nice if all objectURLs in the window object could be revoked with a single call but we couldn't determine if it's supported.

More background info here: https://w3c.github.io/FileAPI/#lifeTime

@evktalo evktalo added bug Something isn't working internals labels Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internals
Projects
None yet
Development

No branches or pull requests

1 participant