Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Bump SkiaSharp from 2.X to 3 Preview #233

Open
1 task done
sirdoombox opened this issue Jun 29, 2024 · 0 comments
Open
1 task done

[Feat] Bump SkiaSharp from 2.X to 3 Preview #233

sirdoombox opened this issue Jun 29, 2024 · 0 comments
Labels
enhancement New feature or request upstream Issues happened on upstreams (Avalonia, Skiasharp...)

Comments

@sirdoombox
Copy link
Collaborator

Check the following items

  • I have looked up relevant Issue

Description of new feature

I thought I'd include this as an issue so that it can be discussed, I think broadly there is a decent chunk for us to be gained and so far I'm not seeing any real downsides. It's not a silver bullet to our performance woes by any stretch and it doesn't represent some major change for us but I think it's worth discussing.

Official support for SkiaSharp 3 will only come when SkiaSharp 3 itself releases, and at this point in time it's not clear when that will be.

I have gotten this running locally on a branch to make sure there were no major hurdles and here's what I found:

  • Performance improvement is fairly mild, jumped from ~155fps to ~170, CPU/GPU utilisation seems to be the same.
  • Only one or two changes to the SkiaSharp API, just method renaming more than anything else, not a huge barrier on our end.
  • No more polyfills needed in shader code, methods like mod step atan etc. are all now available.
  • No requirements for developers to do anything, I simply bumped the version in the SukiUI library project and the implicitly installed version in the demo project reflected that change.
  • Support for SkiaSharp 3 is still technically in preview as is SkiaSharp itself, however I saw no issues in the demo app.

Package Version


Additional Information

No response

@AuroraZiling AuroraZiling added enhancement New feature or request upstream Issues happened on upstreams (Avalonia, Skiasharp...) labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Issues happened on upstreams (Avalonia, Skiasharp...)
Projects
None yet
Development

No branches or pull requests

2 participants