Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused options in the kpm diagnostic help command and from the code #270

Closed
reshmabidikar opened this issue Apr 24, 2024 · 0 comments

Comments

@reshmabidikar
Copy link
Contributor

reshmabidikar commented Apr 24, 2024

The kpm help diagnostic command currently displays the following options:

  [--account-export=ACCOUNT_EXPORT]           # export account for a provided id.
  [--log-dir=LOG_DIR]                         # (Optional) Log directory if the default tomcat location has changed
  [--config-file=CONFIG_FILE]                 # Yml that contains killbill api connection and DB connection
  [--killbill-api-credentials=one two three]  # Killbill api credentials <api_key> <api_secrets>
  [--killbill-credentials=one two three]      # Killbill credentials <user> <password>
  [--killbill-url=KILLBILL_URL]               # Killbill URL ex. http://127.0.0.1:8080
  [--database-name=DATABASE_NAME]             # DB name to connect
  [--database-credentials=one two three]      # DB credentials <user> <password>
  [--database-host=DATABASE_HOST]             # Database Host name
  [--database-port=DATABASE_PORT]             # Database port
  [--kaui-web-path=KAUI_WEB_PATH]             # Path for the KAUI web app
  [--killbill-web-path=KILLBILL_WEB_PATH]     # Path for the killbill web app
  [--bundles-dir=BUNDLES_DIR]                 # A different folder other than the default bundles directory.
  [--overrides=key:value]                     # A hashed list of overrides. Available options are 'url', 'repository', 'username', and 'password'.  
  [--ssl-verify], [--no-ssl-verify]           # Set to false to disable SSL Verification.
                                              # Default: true

Out of these, the --database-name, --database-credentials, --database-host, and --database-port is not used. The code needs to be updated to:

  1. Remove these options from the kpm help diagnostic command
  2. Remove these options from the code where they are referred

The --overrides=key:value and --ssl-verify options are also unused and need to be removed from the kpm help diagnostic command as well.

@reshmabidikar reshmabidikar changed the title Correct the kpm help diagnostic command to display correct options Remove unused options in the kpm diagnostic help command and from the code Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant