Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-upgrade doesn't handle renames in a workspace properly #432

Closed
ordian opened this issue Nov 23, 2020 · 1 comment
Closed

cargo-upgrade doesn't handle renames in a workspace properly #432

ordian opened this issue Nov 23, 2020 · 1 comment

Comments

@ordian
Copy link
Collaborator

ordian commented Nov 23, 2020

If we have multiple versions of a dependency e.g.

[dependencies]
futures = { version = "0.3" }
futures01 = { version = "0.1", package = "futures" }

cargo upgrade will apply renames to both:

[dependencies]
futures = { version = "0.3.8", package = "futures" }
futures01 = { version = "0.3.8", package = "futures" }

Note the first redundant package = "futures".

This is also true if we have at least one rename in a workspace, e.g.

# a.toml
[dependencies]
cargo-edit = "0.7"
# b.toml
[dependencies]
me = { version = "0.7", package = "cargo-edit" }

will be upgraded to

# a.toml
[dependencies]
cargo-edit = { version = "0.7.0", package = "cargo-edit" }
# b.toml
[dependencies]
me = { version = "0.7.0", package = "cargo-edit" }
@epage
Copy link
Collaborator

epage commented Jul 13, 2022

#725 just re did things and we no longer share processing across a workspace, so this should be resolved.

@epage epage closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants