-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should ignore css files by third parties #17
Comments
I am also seeing warnings from my vendor CSS files when I run
|
I can agree that it would make sense to ignore errors (although why would you want to build with css that doesn't work?), but I'm not entirely convinced you wouldn't want to autoprefix your dependencies. Wouldn't you want to enforce your defined targets and/or remove code you don't need? |
Because the errors occur in the Also one could argue it's not our responsibility to improve vendor packages. It's up to the authors of those vendor packages to prefix and minify their CSS. Their repo is the appropriate place to add Autoprefixer, not every package consumer's local environment. Mind the performance hits. I'm seeing these every day and cannot fix...
|
Yeah, I can agree on that. If anyone has ideas on how we could make this change, then feel free to share or make a PR. It's kind of a breaking change, so we'll have to keep that in mind before releasing. Unfortunately, I can't see having time to work on this any time soon. |
What about adding it as an opt-in flag? That would avoid breaking existing projects.
|
I have a bunch of css files in
/public
and/vendor
and auto-prefixer is attempting to parse them. Causing the build to fail because they contain mistakes (out of my scope)The text was updated successfully, but these errors were encountered: