-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse runc-version, not go.mod (vendor.conf) #19
Comments
PR #20 |
thanks, the previous solution was rushed to unblock some kubernetes CI testing and is definitely not robust enough. |
This was referenced May 18, 2021
I am re-running the nightlies after deleting v1.5.1 in particular. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
containerd-nightlies/.github/workflows/main.yml
Lines 38 to 44 in fe50612
This version detection logic is not robust.
As the result, https://github.com/kind-ci/containerd-nightlies/releases/tag/containerd-1.5.1 was released with an unexpected version of runc (expected: rc94, actual: rc93).
The right way is to read
script/setup/runc-version
.https://github.com/containerd/containerd/blob/v1.4.5/script/setup/runc-version
https://github.com/containerd/containerd/blob/v1.5.1/script/setup/runc-version
The text was updated successfully, but these errors were encountered: