Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse runc-version, not go.mod (vendor.conf) #19

Closed
AkihiroSuda opened this issue May 17, 2021 · 3 comments · Fixed by #20
Closed

parse runc-version, not go.mod (vendor.conf) #19

AkihiroSuda opened this issue May 17, 2021 · 3 comments · Fixed by #20

Comments

@AkihiroSuda
Copy link
Contributor

AkihiroSuda commented May 17, 2021

if [ -f go.mod ]; then
RUNC_COMMIT=$(grep opencontainers/runc go.mod | awk '{print $2}')
else
# containerd 1.4 and lower use vendor.conf for the modules
RUNC_COMMIT=$(grep opencontainers/runc vendor.conf | awk '{print $2}')
fi
echo "RUNC_COMMIT=${RUNC_COMMIT}" >> $GITHUB_ENV

This version detection logic is not robust.
As the result, https://github.com/kind-ci/containerd-nightlies/releases/tag/containerd-1.5.1 was released with an unexpected version of runc (expected: rc94, actual: rc93).

The right way is to read script/setup/runc-version.

https://github.com/containerd/containerd/blob/v1.4.5/script/setup/runc-version
https://github.com/containerd/containerd/blob/v1.5.1/script/setup/runc-version

@AkihiroSuda
Copy link
Contributor Author

PR #20

@BenTheElder
Copy link
Collaborator

thanks, the previous solution was rushed to unblock some kubernetes CI testing and is definitely not robust enough.

@BenTheElder
Copy link
Collaborator

I am re-running the nightlies after deleting v1.5.1 in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants