feat(rest): add @kintone/rest package
#3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasshi-me
force-pushed
the
feat/add-rest-js
branch
from
b92375c to
39b1a9a
Compare
tasshi-me
force-pushed
the
feat/add-rest-js
branch
from
39b1a9a to
d0570dc
Compare
shabaraba
requested review from
chihiro-adachi and
shabaraba
and removed request for
a team
tasshi-me
commented
Feb 10, 2025
packages/rest/.gitignore
Outdated
Comment on lines
1
to
3
| esm | ||
| lib | ||
| ndoe_modules |
There was a problem hiding this comment.
先頭に/をつけるようにお願いしますー
（先頭に/がない場合は再帰的にマッチするため）
ref. https://learning.postman.com/docs/tests-and-scripts/run-tests/run-tests-with-ci-cd/
There was a problem hiding this comment.
Suggested change
| esm | |
| lib | |
| ndoe_modules | |
| /esm | |
| /lib | |
| /node_modules |
tasshi-me
commented
Feb 12, 2025
| /** @type {import("eslint").Linter.Config[]} */ | ||
| export default [ | ||
| { | ||
| ignores: ["lib", "esm", "src/schemas"], |
There was a problem hiding this comment.
schemasをignoreするついでにlib, esmも除外
| "fix": "pnpm lint --fix", | ||
| "clean": "rimraf lib esm umd", | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "test:ci": "echo \"TODO: no test specified\"" |
There was a problem hiding this comment.
テストの実行は後続タスクで追加する（まだJestも未導入なので）
| "CHANGELOG.md", | ||
| "esm", | ||
| "lib", | ||
| "!**/*.tsbuildinfo" |
There was a problem hiding this comment.
esm, libの中に*.tsbuildinfoが生成されるのでPublish対象から除外
生成される場所自体を変えることもできるけど、一旦これでOK。
| "openapi-typescript-helpers": "^0.0.15" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "public" |
There was a problem hiding this comment.
scoped packageを一般公開にするにはこの指定が必要
| @@ -0,0 +1,121 @@ | |||
| // FIXME: クライアントをモックしてテスト実行できるようにする | |||
|
|
|||
There was a problem hiding this comment.
テストは諸々後で修正するのでとりあえずeslint-ignoreなども使ってCIを通している
chihiro-adachi
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
How to test
Checklist
pnpm lintandpnpm teston the root directory.