-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest-api-client): supports the upsert option #3118
Conversation
@@ -299,6 +299,7 @@ If you'd like to update over 100 records, please consider using [updateAllRecord | |||
| Name | Type | Required | Description | | |||
| ------------------------- | :--------------: | :-------------------------: | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| app | Number or String | Yes | The app ID. | | |||
| upsert | Boolean | No | Whether to execute in UPSERT mode. If trueis specified, it will be executed in UPSERT mode. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trueis
-> true is
を意図していそう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -332,6 +334,7 @@ For more information, please see [an example of KintoneAllRecordsError](errorHan | |||
| Name | Type | Required | Description | | |||
| ------------------------- | :--------------: | :-------------------------: | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| app | Number or String | Yes | The app ID. | | |||
| upsert | boolean | No | Whether to execute in UPSERT mode. If trueis specified, it will be executed in UPSERT mode. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tureis
こちらも
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chihiro-adachi
updateRecordに組み込むなら良さそうですが、upsertRecordメソッドが別にいるようです。
中身は複数のAPIの出し分けの実装になっているので、こちらを新しい方式に置き換えるでも良いかなと思いました!
@shabaraba upsertRecordメソッドは一括更新ではなく単体更新なので、修正の対象外としました。 |
@shabaraba |
@shabaraba |
Why
The upsert option is now available in the record api.
https://cybozu.dev/ja/kintone/docs/rest-api/records/update-records/
What
The upsert option is now supported.
It can be used with the following methods.
How to test
You can check the operation below.
Checklist
pnpm lint
andpnpm test
on the root directory.