Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention field-snippetfield #7

Open
jenstornell opened this issue Apr 11, 2017 · 1 comment
Open

Naming convention field-snippetfield #7

jenstornell opened this issue Apr 11, 2017 · 1 comment

Comments

@jenstornell
Copy link
Collaborator

@samnabi

one point to consider: following the naming convention of other fields-registered-as-plugins, it might be better to rename kirby-snippetfield.php to field-snippetfield.php.

@louiswalch
Copy link

(Firstly, obsessed with this plugin. As someone who spends way too much time tweaking how the Panel looks - this is perfect.)

I would also agree with this (came in here to add it actually). It doesn't seem the convention to include "kirby-" before the name of plugins for Kirby.

I would also add, I feel "snippetfield" is not entirely accurate. I know of an existing Kirby Field which allows you to select a snippet from your snippets/ folder - so cross over with that. This plugin extends the native structure field so perhaps something like "Structure Snippet Previews" would be more accurate.

Keep up the good works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants