Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Only show button drop shadow in att. lvl 3 on light background #2836

Closed
1 of 9 tasks
RasmusKjeldgaard opened this issue Feb 6, 2023 · 0 comments · Fixed by #2837
Closed
1 of 9 tasks

[BUG] Only show button drop shadow in att. lvl 3 on light background #2836

RasmusKjeldgaard opened this issue Feb 6, 2023 · 0 comments · Fixed by #2837
Assignees
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the bug

When introducing the new att. lvl. 3 button design, the shadow was implemented on all button attention levels on light background, because of a misunderstanding of the design spec:

image

z2 elevation is only meant for att. lvl. 3.

Which Kirby version was used?

Unreleased as of writing this, introduced here: #2735

What was the expected behavior?

Only att. lvl. 3 on light background has shadow, everything else is 'flat' design.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Feb 6, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this to 🔎 Review pending in Kirby Feb 6, 2023
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Feb 6, 2023
@RasmusKjeldgaard RasmusKjeldgaard linked a pull request Feb 6, 2023 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant