Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add desktop functionality to existing modal #2977

Closed
13 of 28 tasks
RasmusKjeldgaard opened this issue Mar 31, 2023 · 0 comments · Fixed by #2995
Closed
13 of 28 tasks

[Enhancement] Add desktop functionality to existing modal #2977

RasmusKjeldgaard opened this issue Mar 31, 2023 · 0 comments · Fixed by #2995
Assignees
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Mar 31, 2023

Describe the enhancement

I would like to have the current modal (not ModalV2) enhanced with desktop styles and functionality during the migration period, so modal becomes a nice fallback until ModalV2 is feature complete. This includes:

  • styling the modal wrapper component with correct paddings for header, footer and content
  • global styles that define width, height and border radius of modal on larger screens
    • multiple desktop sizes according to spec
  • removing drawer styles on desktop so it shows as normal modal
  • show close button to the right instead of arrow down to the left in header on desktop
  • What should happen to the 'open in full height' option?
  • make modal scrollable to bottom on larger screen sizes
  • update tests
  • modal shadow should dynamically scale
  • min-height on fixed t-shirt sizes
  • divider line in header
    • always shown on larger screens
    • should also be shown on mobile but only when modal is scrolled
  • replace border radii with new 32px value
  • make button in feature hint correct color

Known issues that needs fixing

  • Keyboard pushes up modal and limits space - should keyboard appear on top?
  • some modals cannot scroll all the way to the bottom, content is cut off - it has something to do with containment on modal wrapper
    @mixin contain-content() {
      ion-content {
          contain: content;
      }
    }
    

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Mar 31, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this to 🚀 In Progress in Kirby Mar 31, 2023
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Mar 31, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 🔎 Review pending in Kirby May 16, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review pending to 👀 Review in progress in Kirby May 30, 2023
@github-project-automation github-project-automation bot moved this from 👀 Review in progress to ✅ Done in Kirby Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant