Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Alert "OK" button style #3554

Closed
1 of 11 tasks
henrikvoetmand opened this issue Aug 21, 2024 · 0 comments · Fixed by #3623
Closed
1 of 11 tasks

[Enhancement] Alert "OK" button style #3554

henrikvoetmand opened this issue Aug 21, 2024 · 0 comments · Fixed by #3623
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@henrikvoetmand
Copy link
Collaborator

henrikvoetmand commented Aug 21, 2024

Describe the enhancement

In the original Kirby design a positive action was ment to use a "Success" button. (success green button color)
But In DRB positive actions uses brand-primary color buttons (OK, Accept, Confim...)
The "Alert" component is set up to use the "Success" button, but now when we are supporting multiple brands, some PI's find this strange.

Describe the solution you'd like

Change the "OK" button in "Alerts" to use the brand-primary color. (Attention level 1 button)

Have you considered any alternatives?

No!

Are there any additional context?

Alert-btn-color-issue


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Aug 21, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this to ✅ Done in Kirby Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant