Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations? #15

Open
maweki opened this issue Apr 29, 2020 · 1 comment
Open

Type annotations? #15

maweki opened this issue Apr 29, 2020 · 1 comment

Comments

@maweki
Copy link
Collaborator

maweki commented Apr 29, 2020

Up for debate: as we touch up some internal functions and helper methods like I propose in #14, do we want to make mypy-compatible type-annotations while we're at it? If we start from the functions small enough, we might be able to type at least the helper modules.

What do you think?

@kirienko
Copy link
Owner

TL;DR: that would be great.

Well, from one hand, any systematic approach is always welcome. But from the other hand I would do that with a great caution because it's not always clear where and how some particular function is used. Thank Find Usages, we can always check, but that's a big work. That's why IMO it worth doing, but only for fully understood and reviewed parts of code.

@kirienko kirienko pinned this issue Apr 29, 2020
@cydanil cydanil unpinned this issue Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants