Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve scroll position issue with lazy loaded content and link targeting a frame #50

Closed
adrienpoly opened this issue Nov 30, 2023 · 5 comments

Comments

@adrienpoly
Copy link

adrienpoly commented Nov 30, 2023

From 1.3 I noticed what I think is a bug with the way the scroll is preserved.

Lazy loaded content

I have a view with lazy loaded content. (infinite scroll). While I am scrolling down new content will appear but now as the new content appear I am being scrolled UP creating a strange effect.

Links targeting a frame

another case is when I have a link that targets a Turbo Frame. By example a link that will show some content in a text zone. Then same thing the preserve scroll will kick in and break the usual UX.

@jwilsjustin
Copy link

Looks like this may have been fixed with #47. It's merged into main, but hasn't been released yet 👍

@kirillplatonov
Copy link
Owner

Published v1.3.1 with the fix from #47. @adrienpoly please let me know if it solves the issue for you.

@jwilsjustin
Copy link

I quick look at our implementation and the 1.3.1 release looks great! Thanks @kirillplatonov!

@kirillplatonov
Copy link
Owner

Awesome! 🎉

@adrienpoly
Copy link
Author

I confirm that this fixed my issues thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants