Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude vendor dir from matching ... #124

Closed
omarkohl opened this issue Aug 25, 2017 · 3 comments
Closed

exclude vendor dir from matching ... #124

omarkohl opened this issue Aug 25, 2017 · 3 comments

Comments

@omarkohl
Copy link

omarkohl commented Aug 25, 2017

I realize a similar feature was already proposed (and rejected) in #111 but now Go 1.9 changed the behavior of the Go tools such as "go test" and "go vet" to ignore the vendor directory when using triple dot (...) . See golang/go#19090

How about doing the same thing for errcheck? It makes sense to have different Go tools behave similarly.

@dominikh
Copy link
Collaborator

Related: kisielk/gotool#16

@kisielk
Copy link
Owner

kisielk commented May 17, 2018

Is this fixed as a result of the gotool change?

@dmitshur
Copy link
Contributor

dmitshur commented May 17, 2018

That's right. As of kisielk/gotool#16 being resolved, gotool will not include "vendor" directories when expanding "..." on Go 1.9 and later.

@kisielk kisielk closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants