Micropython update #2

amirgon · 2019-01-17T23:54:36Z

@kisvegabor The main things we discussed are implemented here:

structs support, including colors structs, styles, themes, global fonts, etc.
gc support
Symbols support
Added example. This is actually @rreilink's advanced example which I ported to Micropython. There are still many differences between the Python and Micropython syntax (unfortunately), but it does the same thing.
The Makefile now runs gen_mpy.py, generates the bindings and builds them automatically. The commited lv_mpy.c remains as an example, it is not part of the build and doesn't have to be aligned with lv_conf.h. The actual generated lv_mpy.c is generated under build directory.

Still open issues:

There is no naming convention to identify "private" functions or structs. So all functions are bound, including many I assume the user should not be exposed to (such as ll_... functions). I suggest adding a single underscore to any "private" function or struct.
I don't handle arrays yet (to allow using functions such as lv_line_set_points or updating structs such as lv_chart_series_t). I'll add this in the future, I plan to allow the user pass a native python list and convert it automatically, but I still need to think about it.
Macros are not handled. Except from Symbols which I implemented, we still need to handle color macros. I suggest adding inline functions in addition to macros, both functions for converting colors and functions for the colors themselves. Something like static inline lv_color_t lv_get_color(int color_id). The advantage of using inline functions is that the compiler optimizes them down to a constant when possible, so they cost same as using the color macros directly (same in program-memory, data-ram and performance terms)
It's not really tested, except from some very simple examples. I guess there are multiple issues that are still to be discovered, I hope to get inputs from users once this goes to a formal release.

So - in order to release this on the v5.3, what do you need? Should I merge the changes to v5.3 branch and send you a PR to lvgl repo?

… Update makefile to generate lv_mpy.c automatically under /build dir. Use make all to build

…hread safe. It will be called from mp_lv_task_handler which is called periodically from the same thread Micropython is running. Also - update lvgl submodule

embeddedt · 2019-01-19T00:16:30Z

@amirgon I think you should rename the sample lv_mpy.c to lv_mpy_example.c. Otherwise a user may become confused and think that they can modify that lv_mpy.c to do what they want.

amirgon · 2019-01-19T22:58:25Z

@embeddedt Renamed.
@kisvegabor I made some changes in lv_colors.h to expose OPA macros and LV_COLOR_HEX macros to Micropython.

kisvegabor · 2019-01-21T05:02:57Z

Thank you for the update.

There is no naming convention to identify "private" functions or structs. So all functions are bound, including many I assume the user should not be exposed to (such as ll_... functions). I suggest adding a single underscore to any "private" function or struct.

It's quite reasonable, great idea!

I don't handle arrays yet (to allow using functions such as lv_line_set_points or updating structs such as lv_chart_series_t). I'll add this in the future, I plan to allow the user pass a native python list and convert it automatically, but I still need to think about it.

No problem, it's still an experimental version.

It's not really tested, except from some very simple examples. I guess there are multiple issues that are still to be discovered, I hope to get inputs from users once this goes to a formal release.

Yes, we will see. After the release let"s open a an issue for Micropython binding feedback.

So - in order to release this on the v5.3, what do you need? Should I merge the changes to v5.3 branch and send you a PR to lvgl repo?

Yes, please!

amirgon · 2019-01-21T07:33:57Z

It's quite reasonable, great idea!

@kisvegabor I would like to rename private functions/structs, but I'm not sure which should really be private (never allow user access) and which should still be available for the user in some cases.
Could you help listing the private functions/structs? If you do I'll rename them (underscore prefix) in my PR.

kisvegabor · 2019-01-21T07:54:21Z

Basically, everything in the header files is public. As I see now only the global symbols (things form the header files) are added to the binding.

Before renaming let's merge the current version to see these updates in action. In addition, the renaming might cause conflicts so better to have a "stable base".

kisvegabor · 2019-01-21T07:56:42Z

In littlevgl organization, we created separate repos for each project. I will move this one there too once this PR is merged.

So first we should merge the updates for lvgl and then this PR with the updated submodule.

…rely on lvgl.h instead of including the objects directly. This adds themes to the generated binding

…E_LV_TILEVIEW USE_LV_TABLE USE_LV_SPINBOX USE_LV_CANVAS because there are unimplemented functions there which causes lv_mpy.c (which wrap them) to fail linking

…cropython bindings and lvgl submodule (Micropython bindings was split from lvgl).

Fix issues with Makefile

asan considers that memcmp(p, q, N) is permitted to access N bytes at each of p and q, even for values of p and q that have a difference earlier. Accessing additional values is frequently done in practice, reading 4 or more bytes from each input at a time for efficiency, so when completing "non_exist<TAB>" in the repl, this causes a diagnostic: ==16938==ERROR: AddressSanitizer: global-buffer-overflow on address 0x555555cd8dc8 at pc 0x7ffff726457b bp 0x7fffffffda20 sp 0x7fff READ of size 9 at 0x555555cd8dc8 thread T0 #0 0x7ffff726457a (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a) lvgl#1 0x555555b0e82a in mp_repl_autocomplete ../../py/repl.c:301 lvgl#2 0x555555c89585 in readline_process_char ../../lib/mp-readline/re lvgl#3 0x555555c8ac6e in readline ../../lib/mp-readline/readline.c:513 lvgl#4 0x555555b8dcbd in do_repl /home/jepler/src/micropython/ports/uni lvgl#5 0x555555b90859 in main_ /home/jepler/src/micropython/ports/unix/ lvgl#6 0x555555b90a3a in main /home/jepler/src/micropython/ports/unix/m lvgl#7 0x7ffff619a09a in __libc_start_main ../csu/libc-start.c:308 lvgl#8 0x55555595fd69 in _start (/home/jepler/src/micropython/ports/uni 0x555555cd8dc8 is located 0 bytes to the right of global variable 'import_str' defined in '../../py/repl.c:285:23' (0x555555cd8dc0) of size 8 'import_str' is ascii string 'import ' Signed-off-by: Jeff Epler <jepler@gmail.com>

amirgon added 12 commits January 3, 2019 22:39

updated lvgl mpy script

c357ca6

update gen_mpy.py

14a0dfb

Set up custom malloc to use Micropython m_alloc, enabling gc on lvgl.…

41b6901

… Update makefile to generate lv_mpy.c automatically under /build dir. Use make all to build

added example

66c28ad

small makefile fixes

e734887

Add and enable lvgl mpy gc support

9358a56

small bugfix in lvgl example

a4e2b76

Don't call lv_task_handler from SDL thread! Micropython-lvgl is not t…

c3dee8d

…hread safe. It will be called from mp_lv_task_handler which is called periodically from the same thread Micropython is running. Also - update lvgl submodule

update lvgl example

0697cdf

Update lvgl. Makefile DEBUG with -g3 will add macros to debug symbols

bc9519c

update lvgl

86a0edd

update lvgl module

69a3efa

amirgon mentioned this pull request Jan 17, 2019

Feature suggestion: Micropython binding lvgl/lvgl#557

Closed

amirgon added 2 commits January 18, 2019 22:19

update lvgl module

95d2676

lvgl module update

09abca1

update lvgl module

44ef41d

amirgon added 5 commits January 22, 2019 00:09

Updated lvgl module. Updated gen_mpy.py commmand line on makefile to …

0b05d16

…rely on lvgl.h instead of including the objects directly. This adds themes to the generated binding

submodule lvgl switched to dev-5.3 branch. disabled the following: US…

00c12ee

…E_LV_TILEVIEW USE_LV_TABLE USE_LV_SPINBOX USE_LV_CANVAS because there are unimplemented functions there which causes lv_mpy.c (which wrap them) to fail linking

update lvgl module

a843b65

update lvgl module with example binding

f34804d

Replaced lvgl with lv_bindings submodule. lv_bindings contains the Mi…

c34548a

…cropython bindings and lvgl submodule (Micropython bindings was split from lvgl).

amirgon mentioned this pull request Jan 24, 2019

Dev 5.3 Micropython bindings lvgl/lvgl#746

Merged

kisvegabor merged commit 396b68a into lvgl:master Jan 24, 2019

embeddedt pushed a commit that referenced this pull request Aug 7, 2019

Merge pull request #2 from littlevgl/pmpp_6_fix

dfc79bc

Fix issues with Makefile

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Micropython update #2

Micropython update #2

amirgon commented Jan 17, 2019 •

edited

Loading

embeddedt commented Jan 19, 2019

amirgon commented Jan 19, 2019

kisvegabor commented Jan 21, 2019

amirgon commented Jan 21, 2019

kisvegabor commented Jan 21, 2019 •

edited

Loading

kisvegabor commented Jan 21, 2019

Micropython update #2

Micropython update #2

Conversation

amirgon commented Jan 17, 2019 • edited Loading

embeddedt commented Jan 19, 2019

amirgon commented Jan 19, 2019

kisvegabor commented Jan 21, 2019

amirgon commented Jan 21, 2019

kisvegabor commented Jan 21, 2019 • edited Loading

kisvegabor commented Jan 21, 2019

amirgon commented Jan 17, 2019 •

edited

Loading

kisvegabor commented Jan 21, 2019 •

edited

Loading