Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace version in libraryDependencySchemes #34

Open
kubukoz opened this issue Jul 22, 2022 · 1 comment
Open

Don't replace version in libraryDependencySchemes #34

kubukoz opened this issue Jul 22, 2022 · 1 comment

Comments

@kubukoz
Copy link

kubukoz commented Jul 22, 2022

This behavior surprised me: I have this set up in a build

ThisBuild / libraryDependencySchemes ++= Seq(
  "io.circe" %% "circe-core" % "early-semver",
  "io.circe" %% "circe-numbers" % "early-semver",
  "io.circe" %% "circe-jawn" % "early-semver",
  "io.circe" %% "circe-parser" % "early-semver"
)

and then some dependencies like "io.circe" %% "circe-parser" % "0.14.2",. The tool updated the early-semver strings to say 0.14.2, which is not valid. I think it should only replace strings where the "previous" value matches the number shown in the version diff.

@kitlangton
Copy link
Owner

👍 Good bug! Will fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants