Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Search: option to ignore upper and lower case #4980

Closed
m-kotzyba opened this issue Feb 10, 2022 · 6 comments · Fixed by #5363
Closed

Extended Search: option to ignore upper and lower case #4980

m-kotzyba opened this issue Feb 10, 2022 · 6 comments · Fixed by #5363
Assignees

Comments

@m-kotzyba
Copy link
Collaborator

It would be helpful to select whether upper and lower case in the filter query strings are considered or not.

@matthias-ronge
Copy link
Collaborator

Here we probably have to take into account that this setting has to be made before indexing, and requires re-indexing everything if it is changed. Then this topic is not “easy” to deal with.

My expectation of a search engine is actually that case is not distinguished. Can you give me an example of a use case when distinguishing case in search is needed?

@m-kotzyba
Copy link
Collaborator Author

We have process titles including signatures, such as :

X-G-79-30-Lang-Harzgebirge
KM-Byri-1
Schweiz-Wochenschrift-Pharmacie-10-1872
Schweitzer-Harz-Literatur-1

but also process titles including ATS, such as:

BrauHe_129945684_1965
SchwZefP_166820989

It would ease the daily work and reduce possible errors if we could just search for „schweiz“ or „km-byri“.

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Feb 14, 2022

My question was meant the other way round: Do you have a case where you want, that searching for „schweiz“ does not return „Schweiz-Wochenschrift-Pharmacie-10-1872“ and „Schweitzer-Harz-Literatur-1“, but searching for „Schweiz“ does?

What I read from your post, you want case to be ignored, which is what I also think should be the default.

@m-kotzyba
Copy link
Collaborator Author

You are right, I misunderstood the question. Than my Answer is:

No, I can not give you an example where distinguishing the case in search is needed because we always try to make the process titles unique independent of the case.

@matthias-ronge
Copy link
Collaborator

Goal: search should be case-insensitive

@thomaslow
Copy link
Collaborator

There seems to be no easy way in ElasticSearch to make case-sensitivity optional at query time. They tried to implement this feature, see elastic/elasticsearch#61162, but didn't go through with it. Theoretically, we could index each property (e.g. the process title) both in a lower-case variant and the original cased variant.

Since you agreed that this is not important, I modified the indexing to apply a lower-case filter to a few relevant properties, see pull request #5363.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants