fix(PolyDataReader): Apply uniform reader API

BREAKING CHANGE: Legacy/PolyDataReader: parse => parseAsText
Kitware · Feb 7, 2018 · 0d5a5d5 · 0d5a5d5
1 parent d285399
commit 0d5a5d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/BREAKING_CHANGES.md b/BREAKING_CHANGES.md
@@ -24,6 +24,8 @@ Add more consistency in Readers
   - parseAsArrayBuffer(ArrayBuffer) or parseAsText(String)
 - Affected readers:
   - STLReader
+  - Legacy/PolyDataReader
+
 
 ## From 4.x to 5
 

diff --git a/Sources/IO/Legacy/PolyDataReader/index.js b/Sources/IO/Legacy/PolyDataReader/index.js
@@ -42,11 +42,11 @@ function vtkPolyDataReader(publicAPI, model) {
   // Fetch the actual data arrays
   publicAPI.loadData = (option = {}) => {
     const promise = fetchData(model.url, option);
-    promise.then(publicAPI.parse);
+    promise.then(publicAPI.parseAsText);
     return promise;
   };
 
-  publicAPI.parse = (content) => {
+  publicAPI.parseAsText = (content) => {
     if (!content) {
       return;
     }
@@ -63,7 +63,7 @@ function vtkPolyDataReader(publicAPI, model) {
   };
 
   publicAPI.requestData = (inData, outData) => {
-    publicAPI.parse(model.parseData);
+    publicAPI.parseAsText(model.parseData);
   };
 }