Add python depends #455
Merged
Add python depends #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
force-pushed
the
add-plain-python-requirements
branch
from
3746d45
to
99e33ad
Compare
misl6
force-pushed
the
add-plain-python-requirements
branch
from
99e33ad
to
62d41e2
Compare
AndreMiras
requested changes
May 7, 2020
There was a problem hiding this comment.
Pretty cool, so you're making it possible not to have to explicitly:
python toolchain.py pip install certifi
So now basically we can just add python_depends to the recipes that have such dependency?
Could you rebase the PR on master so I can give it a try and potentially merge?
misl6
force-pushed
the
add-plain-python-requirements
branch
from
62d41e2
to
9f95466
Compare
misl6
force-pushed
the
add-plain-python-requirements
branch
from
9f95466
to
85177f5
Compare
AndreMiras
approved these changes
May 9, 2020
|
Nice work, I gave it a try runtime with netiface adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds python_depends in recipe.
It's needed, for example, to include
certifiwhen building kivy.