More fixes to Numpy so that the binary is accepted by the App Store #473
Conversation
There was a problem hiding this comment.
Great findings, thanks for the pull request!
This is actually hard to understand without the full context. It feels like "why are we ever just renaming functions".
Digging around I understood, the Apple store automatic app checks get mislead as if we were trying to reference to Apple non public symbols while we actually reference our own private symbols.
As this is a rather tricky one and could be overlooked and reverted by mistake in the future I would give special care by either commenting the patch file itself comprehensively or having a more detailed commit message, at least the reference to the bug #409
The problem is with or without this patch numpy would comply properly hence we may break what you just fixed (Apple store submission) without realising.
Last thing, have you reported the bug to numpy upstream (to save other people time)? Because applying the fix is actually simple, but digging it probably was painful
recipes/numpy/numpy-1.16.4.patch
Outdated
| return [] | ||
| return [all_sources[0]] | ||
|
|
||
| + def get_lapack_lite_sources_ios(ext, build_dir): | ||
| + return [] | ||
| + return [all_sources[0]] |
There was a problem hiding this comment.
isn't this ending up behaving the same way as originally before being patched at all?
https://github.com/numpy/numpy/blob/v1.16.4/numpy/linalg/setup.py#L39
|
It seems to me that Numpy is referencing private Apple symbols as the file umath_linalg.c.src only wraps BLAS and LAPACK routines. Since An explanation could be that these symbols are only private on iOS, which would explain why Numpy is working fine on MacOS. I will report these findings to them, thanks for the suggestion! |
lerela
force-pushed
the
409_numpy_issues
branch
2 times, most recently
from
14376ba
to
79e0d19
Compare
|
OK that makes even more sense now thank you. |
Explanation: Apple forbids some symbols that Numpy is linked against (ccopy, dcopy, scopy, zcopy and xerbla). Compilation and tests work fine but the App Store complains and prevents uploading such builds. This patch aliases the culprits to the public, allowed method names, allowing the linking to proceed as before and the resulting binary to be accepted by the App Store.
|
Done, however I've not rebuilt Kivy/Numpy with the new structure to make sure it'd work! |
|
Thanks! And the CI built it green for you it seems :) |
See #409 for context