Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove distribute recipe #507

Merged
merged 1 commit into from
May 27, 2020
Merged

Remove distribute recipe #507

merged 1 commit into from
May 27, 2020

Conversation

Zen-CODE
Copy link
Member

@Zen-CODE Zen-CODE commented May 26, 2020 •
edited
Loading

distribute is a legacy package and I would argue should be removed for these reasons:

  • Its last release was 2013.
  • Its last supported Python version is 3.3.
  • It is not used in any other recipes.
    Seems pretty pointless keeping it to me?

closes #466

AndreMiras
AndreMiras approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to give a bit of context this is an old wrapper, but it's legacy and no longer maintained upstream

@Zen-CODE Zen-CODE merged commit 4587515 into master May 27, 2020
@Zen-CODE Zen-CODE deleted the fix/distribute branch May 27, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distribute recipe broken (no attribute 'SourceFileLoader')
2 participants
@Zen-CODE @AndreMiras