Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiecutter: Fixes header and library search paths on Release #582

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jan 5, 2021

I noticed that the HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS used in the Release configuration are wrong.

I personally use a custom workspace, so I never noticed 🤐

@Cheaterman
Copy link
Contributor

Cheaterman commented Jan 19, 2021

Hahaha, it's a bunch of huge catches you're doing these days! It's almost surprising it all worked before Xcode 12, hahaha... Thanks for that - I'm uploading my file in Debug mode for now (too many days of work spent on this, I'm tired and I have other things piling up), but it sure will be great when this is tested and merged :-) thanks again!

EDIT: Also « I personally use a custom workspace, so I never noticed 🤐 » makes me think it's good someone who actually knows these Xcode things takes a look at this ^^ most contributors (me included) are fairly novice at these things and kind of forced into doing it, hehehe, at least I know I am 🙂

@misl6
Copy link
Member Author

misl6 commented Jan 23, 2021

The provided fix seems to work:
See #572 (comment)

Copy link
Member

@Zen-CODE Zen-CODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks :-)

@Zen-CODE Zen-CODE merged commit 34add6c into kivy:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants