Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[revamp] p4a silently fails if --private is not absolute #448

Closed
str4d opened this issue Sep 12, 2015 · 3 comments
Closed

[revamp] p4a silently fails if --private is not absolute #448

str4d opened this issue Sep 12, 2015 · 3 comments

Comments

@str4d
Copy link
Contributor

str4d commented Sep 12, 2015

This one tripped me up for a while, because the documentation (both master and revamp) was not clear on where the entry point to the Python code should go. But eventually I discovered that if --private is given a relative path (on Linux), it silently fails: assets/private.mp3 is successfully built without any of the app code, resulting in an APK that installs but doesn't start.

Either --private should be extended to support relative paths, or the documentation should say they aren't supported, and p4a should fail loudly.

@inclement
Copy link
Member

This is just a bug, relating to how p4a switches directory contexts - it holds the correct directory for relative path resolution in a variable but doesn't always correctly apply it. Thanks for reporting it.

@inclement
Copy link
Member

(Oops, wrong issue)

@inclement
Copy link
Member

This should be fixed by dfc8ab3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants