Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "--window" option #666

Closed
pythonic64 opened this issue Mar 4, 2016 · 4 comments
Closed

No "--window" option #666

pythonic64 opened this issue Mar 4, 2016 · 4 comments

Comments

@pythonic64
Copy link
Contributor

Doing:

p4a apk <other arguments> --window

with SDL2 as bootstrap raises error:

p4a: error: unrecognized arguments: --window

Is there another way to set windowed mode?

@inclement
Copy link
Member

Apparently this option hasn't yet been added to the SDL2 build.py. You can use it with SDL2 by adding the code (a PR for this would be welcome), or possibly by doing it at runtime with pyjnius (though that's undesirable).

The option still exists when --bootstrap=pygame, though this backend will eventually be deprecated and SDL2 is the focus of our development efforts.

@pythonic64
Copy link
Contributor Author

On the first look, it seems that this line:

<meta-data android:name="fullscreen" android:value="{% if args.window %}0{% else %}1{% endif %}"/>

should be added here.

@inclement
Copy link
Member

Looks good. You'd also need to add the --window option in the build.py, I think.

@inclement
Copy link
Member

Should be fixed by the merged PR above, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants