Revisit exception handling and logging in Async for potential improvements #1133
sleberknight
started this conversation in
General
Replies: 1 comment
-
Structured Concurrency will be a general alternative to |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We made slight improvements to
Async
's exception logging in #731 but it's far from perfect, especially in thewithMaxTimeout
method which wraps aCompletableFuture
in anotherCompletableFuture
in order to allow calls to proceed asynchronously, but still have a maximum timeout. The current logging can be quite confusing to read when the max timeouts are exceeded.This task is to investigate whether there is a better way to handle interruptions,
ExecutionException
, orTimeoutException
and whether we can make it more clear in the logs what went wrong.It might also be that this is just not a great way of doing this, and maybe we ought to investigate whether the JDK or other libraries have a better solution (I'm sure someone, somewhere does...)
Beta Was this translation helpful? Give feedback.
All reactions