Consider adding utilities related to java.time.Duration

[sleberknight]

I've recently been annoyed that java.time.Duration contains isZero() and isNegative() methods but no other variants. My specific use case called for checking if a Duration was zero or positive, which meant I had to use !duration.isNegative(). It's obviously not a huge problem, but reading:

if (!duration.isNegative()) {
    // do something...
}

is less clear and takes more time for a reader to parse than:

if (duration.isPositiveOrZero()) {
    // do something...
}

Especially since you might quickly read "not negative" as "positive" and not "zero or positive". (Or maybe that's just me).

Since I clearly can't add what I want to java.time.Duration (unless Java ever adds extension methods like in Kotlin and other languages), we could add some methods to a KiwiDurations utility to cover the common cases of:

boolean isPositive()

boolean isPositiveOrZero()

boolean isNegativeOrZero()

[sleberknight]

I just checked Apache Commons Lang and it contains a DurationUtils class with some useful methods, including isPositive(Duration). It unfortunately does not, however, have isPositiveOrZero, which means we'd still need to do:

if (duration.isZero() || DurationUtils.isPositive(duration)) { ... }

This code is also a bit annoying since one method is an instance method and the other is a static method, so it looks inconsistent. Nit picky? Sure. But I guess I'd rather just call one method in a consistent way.

[sleberknight]

Closing this as it will be fixed by #1221 in version 4.6.0