Consider changing kiwi PagingParams to use our own KiwiSort.Direction instead of Spring Data's Sort #677
Replies: 1 comment
-
Actually a better way to go about this at present is to replace (some) classes in kiwi's
If necessary, we can also create adapter methods to translate between Essentially, these and possibly other classes would be copied to a new generic package, and deprecate the existing ones, possibly for removal in a future version. |
Beta Was this translation helpful? Give feedback.
-
The kiwi
PagingParams
currently uses Spring Data'sSort.Direction
but really should not use it.In addition, this entire paging infrastructure could be moved outside the
org.kiwiproject.spring.data
package and into a more generic one, e.g.org.kiwiproject.search.paging
or similar.At first glance, the classes in
org.kiwiproject.spring.data
that are generic in nature (or could be made generic) include:KiwiPage
KiwiSort
KiwiSort.Direction
PagingParams
PagingRequest
The rest of the classes in
org.kiwiproject.spring.data
(as of this writing) are directly dependent on Spring Data APIs, so this would entail splitting the existing package such that theorg.kiwiproject.spring.data
package depends on the new, generic package.This would obviously be a breaking change to a public API and so should be done by first deprecating the existing classes, and then releasing the changes in a new major version of kiwi.
Beta Was this translation helpful? Give feedback.
All reactions