Consider extracting the error checking logic from ClientPollerTimeBasedHealthCheck into generic kiwi utility #678
sleberknight
started this conversation in
Ideas
Replies: 1 comment
-
Another thought is that we could make use of the AutoDrainingCounter in kiwi-beta somehow and maybe add that to kiwi as well as provide a health check around that concept too. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
ClientPollerTimeBasedHealthCheck
in dropwizard-client-poller contains some code to calculate the maximum number of allowed poll errors in a given time window. Consider making this generic, though not sure exactly where this would go in kiwi package-wise.We might consider whether it's possible (or desirable) to also create a health check that encapsulates this concept of time-based error counting with an allowable threshold of errors.
So you would have:
If the health check isn't possible, just creating the utility would probably still be worthwhile.
References:
Beta Was this translation helpful? Give feedback.
All reactions