Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in test: KiwiIOTest.CloseQuietly.shouldClose_XMLStreamWriter #1177

Closed
sleberknight opened this issue Jul 31, 2024 · 0 comments · Fixed by #1176
Closed

Fix bug in test: KiwiIOTest.CloseQuietly.shouldClose_XMLStreamWriter #1177

sleberknight opened this issue Jul 31, 2024 · 0 comments · Fixed by #1176
Assignees
@sleberknight
Labels
bug Something isn't working
Milestone
4.2.0

Comments

@sleberknight
Copy link
Member

This test throws a javax.xml.stream.XMLStreamException when the XMLStreamWriter is closed using KiwiIO.closeQuietly, with the error message:

Trying to write END_DOCUMENT when document has no root (ie. trying to output empty document).

As a result, we were not testing the case when closing it succeeds.

To fix, it can either be mocked, or we can use the XMLStreamWriter to write a simple XMl document, then close it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
bug Something isn't working
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Add methods to KiwiIO that can "close" any object kiwiproject/kiwi
1 participant
@sleberknight