Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract website link from string file for play store restriction dialog. #3625

Closed
MohitMaliFtechiz opened this issue Dec 21, 2023 · 4 comments · Fixed by #3626
Closed

Extract website link from string file for play store restriction dialog. #3625

MohitMaliFtechiz opened this issue Dec 21, 2023 · 4 comments · Fixed by #3626
Assignees
Milestone

Comments

@MohitMaliFtechiz
Copy link
Collaborator

Describe the bug
Extract the website link from the string file for the Play Store restriction dialog. Since it is not available to translate on translate wiki.

Screenshot from 2023-12-21 18-52-45

@MohitMaliFtechiz MohitMaliFtechiz self-assigned this Dec 21, 2023
@MohitMaliFtechiz MohitMaliFtechiz added this to the 3.9.1 milestone Dec 21, 2023
@MohitMaliFtechiz MohitMaliFtechiz changed the title Extract website link from string file for play store restrcition dialog. Extract website link from string file for play store restriction dialog. Dec 21, 2023
@kelson42
Copy link
Collaborator

kelson42 commented Dec 22, 2023

I don’t understand this ticket. Always keep in mind that bug reports should be reported primarly from user perspective.

@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 On the upstream our website link is not available for translation in other languages. If the user checks the Help section in our application there will be no website link available for other languages like it is showing in the English version. And user does not know where to download the APK since there is no link showing.

1703231185445

@kelson42
Copy link
Collaborator

On the upstream our website link is not available for translation in other languages.

I see, but what it is like this? Before fixing the problem, I would like to have a full explanation about the reasons behind it!

@kelson42 kelson42 modified the milestones: 3.9.1, 3.10.0 Dec 25, 2023
@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 We had added the anchor tag in our English version for the website link(Where the user can download the APK) It is showing in the Help screen as shown in the above image. The User can click on that link and it takes the user to our website.

However anchor tags are not available to translate on translateWiki, so the website link will not show in the help screen in other languages of our application. It only shows the text to user without any website link so the user does not know where and from which website he can download the APK. So this behavior might confuse the user so to address this issue we have opened this ticket.

Now, we have extracted the website link from the string file to our coding part because we don't need to translate the link, and attaching this link in text while showing it to the user, as shown in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants