-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] File drawer in Tabs screen #3754
Comments
@MohitMaliDeveloper Domyou understand the bug? confirm it? |
You can simply open the zim drawer(from right side) in tab switcher. I want to restrict it, as it's having no use in tab switcher |
@kelson42 @MohitMaliDeveloper if you got the idea here, then let me know I will start working on it. |
@Sagar0-0 Thanks for opening the issue, and finding a good enhancement.
The right tab switcher acts on the currently selected tab even if the tabs are active user can select the items from the side drawer when the tab switcher is active(So it is not useless here). But yes it should not show the right drawer when the tabs are showing to improve the user experience. |
@Sagar0-0 I have assigned this issue to you. Please make sure the right drawer should re-appear properly with the currently selected tab(with content) after the tab switcher is closed in both modules (app and custom). |
Is the logic for this drawer present in both (app, custom) modules? If yes, then why? |
@Sagar0-0 There is no separate logic for this functionality. The logic is written in |
@Sagar0-0 Any update on this? |
Couldn't find the actual logic to disable the opening and closing of drawer |
@Sagar0-0 OK, thanks for trying i will look into it and place a fix for it. |
@MohitMaliFtechiz Coukd you please implement |
Describe the bug
File drawer is accessible in the Tabs screen which is not valid or required.
Expected behavior
If should not be accessed by swiping from right
Steps to reproduce the behavior:
Screenshots
Environment
Logs
The text was updated successfully, but these errors were encountered: