Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] File drawer in Tabs screen #3754

Closed
Sagar0-0 opened this issue Mar 17, 2024 · 11 comments · Fixed by #3981
Closed

[Improvement] File drawer in Tabs screen #3754

Sagar0-0 opened this issue Mar 17, 2024 · 11 comments · Fixed by #3981
Assignees
Milestone

Comments

@Sagar0-0
Copy link
Contributor

Describe the bug

File drawer is accessible in the Tabs screen which is not valid or required.

Expected behavior

If should not be accessed by swiping from right

Steps to reproduce the behavior:

  1. Go to tab switcher and swipe from right side

Screenshots

00dc0d19-827e-408c-a688-c8959c1c72f0

Environment

  • Version of Kiwix Android : 3.9.0
  • Device : REALME GT
  • OS version : 13

Logs

@kelson42 kelson42 added this to the 3.10.0 milestone Mar 19, 2024
@kelson42
Copy link
Collaborator

@MohitMaliDeveloper Domyou understand the bug? confirm it?

@Sagar0-0
Copy link
Contributor Author

You can simply open the zim drawer(from right side) in tab switcher. I want to restrict it, as it's having no use in tab switcher

@kelson42 kelson42 modified the milestones: 3.10.0, 3.11.0 Mar 20, 2024
@Sagar0-0
Copy link
Contributor Author

@kelson42 @MohitMaliDeveloper if you got the idea here, then let me know I will start working on it.

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Mar 26, 2024

@Sagar0-0 Thanks for opening the issue, and finding a good enhancement.

as it's having no use in tab switcher

The right tab switcher acts on the currently selected tab even if the tabs are active user can select the items from the side drawer when the tab switcher is active(So it is not useless here). But yes it should not show the right drawer when the tabs are showing to improve the user experience.

@MohitMaliFtechiz
Copy link
Collaborator

@Sagar0-0 I have assigned this issue to you. Please make sure the right drawer should re-appear properly with the currently selected tab(with content) after the tab switcher is closed in both modules (app and custom).

@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Apr 9, 2024

Is the logic for this drawer present in both (app, custom) modules? If yes, then why?

@MohitMaliFtechiz
Copy link
Collaborator

@Sagar0-0 There is no separate logic for this functionality. The logic is written in CoreReaderFragment which works for both modules.

@MohitMaliFtechiz
Copy link
Collaborator

@Sagar0-0 Any update on this?

@Sagar0-0
Copy link
Contributor Author

Couldn't find the actual logic to disable the opening and closing of drawer

@MohitMaliFtechiz
Copy link
Collaborator

@Sagar0-0 OK, thanks for trying i will look into it and place a fix for it.

@kelson42 kelson42 modified the milestones: 3.11.0, 3.12.0 May 19, 2024
@kelson42 kelson42 modified the milestones: 3.13.0, 3.12.0 Sep 3, 2024
@kelson42
Copy link
Collaborator

kelson42 commented Sep 3, 2024

@MohitMaliFtechiz Coukd you please implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants