Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad Video.js play pause button state #914

Closed
BPerlakiH opened this issue Aug 5, 2024 · 13 comments
Closed

iPad Video.js play pause button state #914

BPerlakiH opened this issue Aug 5, 2024 · 13 comments
Assignees
Milestone

Comments

@BPerlakiH
Copy link
Collaborator

After closing full screen, the video.js play / pause button is stuck on pause state, it does work, but not updating it’s state.

@BPerlakiH BPerlakiH self-assigned this Aug 5, 2024
@kelson42 kelson42 added this to the 3.5.0 milestone Aug 5, 2024
@kelson42
Copy link
Contributor

I can not reproduce this bug on iOS18. Can we have please a details bug report with a screencast?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 this is the screen recording from iPad iOS 17:

ipad_video_pause_issue.mov

TLDR: the play/pause button works at the beginning, after returning from full-screen, it does work (pauses and plays the video), but the state of the button is not changing.

@BPerlakiH
Copy link
Collaborator Author

These are the 2 states of the button:
Screenshot 2024-08-12 at 23 30 36
Screenshot 2024-08-12 at 23 30 44

@kelson42
Copy link
Contributor

kelson42 commented Aug 12, 2024

@BPerlakiH Old content, not even distributed anymore: please redo a screencast with the most recent ZIM content. Here again I still miss the clear reproduction steps like requested.

@BPerlakiH
Copy link
Collaborator Author

@kelson42 The same issue with newer content, on iPad OS 17:
https://github.com/user-attachments/assets/393eb204-9a9d-4e48-aeb1-411c5e99b7c7

Reproduction steps:

  • start playing a video
  • enter full screen
  • exit full screen, this pauses the video => expect to see the button:
    image
  • play video => expect to see the button:
    image
  • pause video => expect to see the button:
    image

@benoit74
Copy link

To me this looks a lot like Video.JS bug, to be reported to Video.JS repository.

Do you have the same behavior on Safari or with Kiwix app (if you can force it to load a web URL) on https://videojs.com/city?

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Aug 13, 2024

@benoit74
I have tested in Safari and force loaded the url into the Kiwix app, both works fine.
"Our" content is using: Video.js 7.8.1
Whereas the latest release is: 8.17.2

@benoit74
Copy link

Thank you! Sorry for this new test (hopefully the last one), but can you please test https://mirror.download.kiwix.org/zim/videos/deus-ex-silicium_fr_all_2024-08.zim ; it is a (very) fresh ZIM with video.js 8.17.3 (which is not even marked latest, but we needed this in youtube scraper to support Chrome 58 and 59, and video.js maintainer told us it was fine and going to be latest soon).

@BPerlakiH
Copy link
Collaborator Author

@benoit74 No worries.
I've downloaded and tested the ZIM, and it works great.
So, it seems that the video.js update alone can solve this issue for us.

@kelson42
Copy link
Contributor

@benoit74 Can we link here to the issues requesting this version of video.js? For each of the scraper relying ont video.js?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 @benoit74 I have also tested the same ZIM file on the iPhone, there's one behaviour that is different there (compared to other ZIM files), is that the video starts playing immediately as the page loads, and switches to full screen, which makes our other issue with the black start screen more prominent:

ZIM_iPhone_auto_fullScreen.mp4

@BPerlakiH
Copy link
Collaborator Author

I am happy to close this issue, as with the latest ZIM file and video js it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants