Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop having allowing multiple windows #969

Open
kelson42 opened this issue Sep 7, 2024 · 3 comments
Open

Stop having allowing multiple windows #969

kelson42 opened this issue Sep 7, 2024 · 3 comments

Comments

@kelson42
Copy link
Contributor

kelson42 commented Sep 7, 2024

We should jühave only one window to:

  • easily ensure coherency
  • ensure it does not work very differently from other Kiwix
@kelson42 kelson42 changed the title Stop having multiple windows Stop having allowing multiple windows Sep 7, 2024
@benoit74
Copy link

benoit74 commented Sep 9, 2024

I'm significantly not aligned with this change, at least as it is described / justified for now.

As a Mac user, I generally dislike applications which do not support multiple windows (there are few edge cases of course where I know I need only one window in all cases), and I think that I'm not alone, (as rgaudin said) this is quite expected by most Mac users to be able to have multiple windows of the same applications for various use cases.

That being said, I have no idea about the exact cost associated with multiple windows, and it might make sense if we do not have the resources required to maintain a multiple windows application. It would be sad, but that might be our reality, and I prefer a limited but not buggy application. This needs to be a bit more grounded than "it would be simpler".

The argument "ensure it does not work very differently from other Kiwix" makes non sense from my PoV, we do not have any kind of standard behavior across Kiwix readers, and it is even known to be an anti-pattern because each OS/community has its "way of working" and it is recommended to align with them rather than provide a one-size-fit-all solution.

@kelson42
Copy link
Contributor Author

kelson42 commented Sep 9, 2024

@benoit74 Thx for your feedback. @rgaudin has a similar opinion I believe. I will let the issue maturing... or die.

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Sep 9, 2024

I am somewhat aligned with @rgaudin and @benoit74 on this.
Currently to open a link in a new tab is a standard feature across all versions of Apple Kiwix. Detaching a tab from the current window and move it to become a new window, is a standard feature of macOS.
Therefore we have multiple tabs which is equal multiple windows.
I also think that removing tabs or forcing to have a single window would be too much limiting on our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants