Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature does too much of magic #983

Open
kelson42 opened this issue Sep 18, 2024 · 0 comments
Open

Search feature does too much of magic #983

kelson42 opened this issue Sep 18, 2024 · 0 comments

Comments

@kelson42
Copy link
Contributor

Current search is a mix of a fulltext search and suggestions. To allow proper merging of results, the swift code does a bit of magic and heuristics.

This leads to:

  • Complexity in the code
  • Slower computations
  • Discrepencies with other readers

This is not how it should work.

The Kiwix reader should reuse straight the results provided by the libzim.

Here are two proposals to change the behaviour to be more conform:

  • Make a suggestion search per default (like in Kiwix Desktop of Kiwix Android) ie. while user is typing propose titles matching the search pattern. Provide an optional fulltext search if user can/wants (with result snippets)
  • Make a suggestion search per default (like in Kiwix Desktop of Kiwix Android) ie. while user is typing propose titles matching the search pattern... and last item of the suggestion list allow to trigger a fulltext search (this is how works Kiwix Desktop)

FYI, Kiwix Android does not provide yet fulltext search feature.

@kelson42 kelson42 changed the title Searches do to much of magic Search feature does too much of magic Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant