Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Save Translation for Filters in Settings Session #1185

Closed
ShaopengLin opened this issue Aug 22, 2024 · 3 comments
Closed

Do Not Save Translation for Filters in Settings Session #1185

ShaopengLin opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@ShaopengLin
Copy link
Collaborator

From #1175 comment

  1. We should only need to store a list of strings, the filter keys, in the session. The problem comes with backward compatibility as the previous sessions are now invalid. Need to discuss how to best approach this issue.

  2. KiwixChoiceBox needs to adapt to the new session management.

@kelson42
Copy link
Collaborator

kelson42 commented Aug 23, 2024

@ShaopengLin If you don't migrate, the only problem is that people will loose once their categorisation filters, just after software upgrade, right? To me I don't really understand why we should not implement straight this in a PR. Seems trivial.

@kelson42 kelson42 added the bug label Aug 23, 2024
@kelson42 kelson42 added this to the 2.5.0 milestone Aug 23, 2024
@ShaopengLin
Copy link
Collaborator Author

@kelson42 @veloman-yunkan if we are ok with that one time lost, then indeed we can make this change directly. This then should come with #1175, as it will not introduce a huge detour. If you all agree could you close this? I will make the modification back over at #1175.

@kelson42 kelson42 modified the milestones: 2.5.0, 2.4.0 Sep 1, 2024
@veloman-yunkan
Copy link
Collaborator

Fixed by #1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants