Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few things to fix/discuss around zoom #718

Closed
kelson42 opened this issue Nov 11, 2021 · 6 comments · Fixed by #719
Closed

Few things to fix/discuss around zoom #718

kelson42 opened this issue Nov 11, 2021 · 6 comments · Fixed by #719
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Nov 11, 2021

In general the zoom works like this:

  • There is a default zoom level at 100%
  • This default zoom level can be changed in the settings
  • This default zoom level applies to any ZIM, ZIM article if not defined differently.
  • Each ZIM file can have its own level of zoom which is saved in the settings (but not available via UI)
  • This ZIM dedicated ZOOM settings can be changed (and automatically saved in the settings) with the wheel, button, meny entry or shortcuts

To me all of this works properly and as it should. I see only a few things to improve/fix:

  • The settings entry should be labeld "Default zoom level" instead of just "Zoom level"
  • The settings should apply immediatly to all tabs (which don't have already a manually set zoom level).
  • Zoom reset seems not to bring to default zoom level, it seems to bring to 100% works!
@kelson42
Copy link
Collaborator Author

@juuz0 Remember you talking about zoom level (as you were working on the settings panel)... to me it seems to work pretty well.

@juuz0
Copy link
Collaborator

juuz0 commented Nov 11, 2021

@kelson42 Oh yea, I forgot to update. That was working correct for me too later.

Zoom reset seems not to bring to default zoom level, it seems to bring to 100%

Weird, this works as expected for me.

@kelson42
Copy link
Collaborator Author

@juuz0 I have restested, and indeed it seems to work.

@juuz0
Copy link
Collaborator

juuz0 commented Nov 11, 2021

Also, is it better to remove this line (bothers me for some reason lol) and making the arrows black

(I tried it last time but couldn't do it so maybe if someone else takes this up)

image

@juuz0
Copy link
Collaborator

juuz0 commented Nov 11, 2021

@kelson42 How do you generate translations for all these languages?

@kelson42
Copy link
Collaborator Author

@juuz0 strings in english are uploaded to translatewiki.net and once a week translatewiki.net makes a PR with the translated strings.

@kelson42 kelson42 added this to the 2.1.0 milestone Nov 12, 2021
@kelson42 kelson42 removed their assignment Nov 12, 2021
@kelson42 kelson42 added UI User Interface enhancement and removed question labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants