Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix incorrectly claims "not enough storage available" #854

Closed
VorpalBlade opened this issue Jul 1, 2022 · 15 comments · Fixed by #855
Closed

Kiwix incorrectly claims "not enough storage available" #854

VorpalBlade opened this issue Jul 1, 2022 · 15 comments · Fixed by #855
Assignees
Milestone

Comments

@VorpalBlade
Copy link

VorpalBlade commented Jul 1, 2022

I had wikipedia with pictures downloaded since before. I now noticed there was a newer version available and decided to download it.
I removed the old version of wikipedia and went to download the new version. However the following popup shows up:
image

This is incorrect. According to the listing Wikipedia should be 89 GB.

Note output below may look a bit strange looking since kiwix is on it's own btrfs subvolume (to prevent automatic snapshots from including kiwix). However, as can be seen, there is more than double the required space available on this file system.

$ df -h ~/.var/app/org.kiwix.desktop/data
Filesystem      Size  Used Avail Use% Mounted on
-               300G  102G  197G  35% /home/arvid/.var/app/org.kiwix.desktop/data
$ df -h /
Filesystem              Size  Used Avail Use% Mounted on
/dev/mapper/linux-root  300G  102G  197G  35% /

kiwix also complains about storage space for much smaller downloads, such as the 12 GB "introduction only" wikipedia download. However, really small downloads, like wikiquite (684 MB) starts correctly.

System info:

  • Arch Linux x86-64 (rolling release)
  • Kiwix 2.2.2
  • Desktop environment is KDE Plasma 5.25.2
  • File system is btrfs.
  • I installed kiwix via flatpak.
@kelson42
Copy link
Collaborator

kelson42 commented Jul 1, 2022

@VorpalBlade Thx for your tickrt. Which version of Kiwix did you have before?

@mgautierfr
Copy link
Member

What is the output of btrfs filesystem usage ~/.var/app/org.kiwix.desktop/data ?

@juuz0
Copy link
Collaborator

juuz0 commented Jul 2, 2022

I can confirm the bug, anything above 4GB shows this problem for me.

Ubuntu 22.04
Kiwix 2.2.2
Available Space: 67GB
Filesystem: ext4

@kelson42
Copy link
Collaborator

kelson42 commented Jul 2, 2022

I don't understand why the bug only appears now! This is a regression? A bug specific to btrfs?

@kelson42 kelson42 added the bug label Jul 2, 2022
@kelson42 kelson42 added this to the 2.3.0 milestone Jul 2, 2022
@VorpalBlade
Copy link
Author

VorpalBlade commented Jul 2, 2022

@VorpalBlade Thx for your tickrt. Which version of Kiwix did you have before?

Not sure, flatpak auto updates. But it was the latest flatpak from late last year / early this year when I downloaded wikipedia data the previous time, and it worked back then.

What is the output of btrfs filesystem usage ~/.var/app/org.kiwix.desktop/data ?

It complained that it needed to be run with sudo, so I did that.

$ sudo btrfs filesystem usage ~/.var/app/org.kiwix.desktop/data
Overall:
    Device size:		300.00GiB
    Device allocated:		114.07GiB
    Device unallocated:		185.93GiB
    Device missing:		    0.00B
    Used:			102.21GiB
    Free (estimated):		195.82GiB	(min: 102.85GiB)
    Free (statfs, df):		195.82GiB
    Data ratio:			     1.00
    Metadata ratio:		     2.00
    Global reserve:		162.38MiB	(used: 0.00B)
    Multiple profiles:		       no

Data,single: Size:110.01GiB, Used:100.12GiB (91.01%)
   /dev/mapper/linux-root	110.01GiB

Metadata,DUP: Size:2.00GiB, Used:1.04GiB (52.25%)
   /dev/mapper/linux-root	  4.00GiB

System,DUP: Size:32.00MiB, Used:16.00KiB (0.05%)
   /dev/mapper/linux-root	 64.00MiB

Unallocated:
   /dev/mapper/linux-root	185.93GiB

I don't understand why the bug only appears now! This is a regression? A bug specific to btrfs?

Definitely a regression. It worked before for me on btrfs late last year or early this year. I don't have any non-btrfs system to test with. However @juuz0 said they had the same issue and they ext4.

@VorpalBlade
Copy link
Author

I can confirm the bug, anything above 4GB shows this problem for me.

That sounds to me like someone used an unsigned 32-bit integer by mistake somewhere.

@mgautierfr
Copy link
Member

I suspect this commit b49ea7c and especially the appearing 'unsigned'

@juuz0
Copy link
Collaborator

juuz0 commented Jul 2, 2022

Yeah right. That must be it since a build from 9e0575a works fine

@kelson42
Copy link
Collaborator

kelson42 commented Jul 2, 2022

@juuz0 Would you be able to make a PR to fix it? We will have to make a new release irgently.

@kelson42
Copy link
Collaborator

kelson42 commented Jul 3, 2022

A nightly, with the fix, will be available in a few hours at http://download.kiwix.org/nightly/2022-07-03/

@Bleda412
Copy link

Bleda412 commented Jul 4, 2022

A nightly, with the fix, will be available in a few hours at http://download.kiwix.org/nightly/2022-07-03/

I am a bit of a boomer. How exactly do I install this fix?

@kelson42
Copy link
Collaborator

kelson42 commented Jul 4, 2022

@Bleda412 download http://download.kiwix.org/nightly/2022-07-03/kiwix-desktop_windows_x64_2022-07-03.zip

@Bleda412
Copy link

Bleda412 commented Jul 4, 2022

@kelson42 I just did that. Not sure if this is intended but when I run the program, a command prompt comes up and stays up. When I tried to download Wikipedia, it stopped responding after 39MB, which happened almost instantly.
I don't mean to pester you with this reply, just letting you know it doesn't work for me just yet. Thanks for working on a fix.

@scottmayo
Copy link

scottmayo commented Aug 15, 2022

Fails on ubuntu with 600G free, as described by others.
I managed to find the nightly build for 8-15, and it worked as expected, but the default download on the website is still the broken version.

@kelson42
Copy link
Collaborator

Yes, we are working on the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants