Tab graphic bug

[gmikhail]

Unnecessary tab separator is displayed when opening a new tab:

And when you close tab it disappears:

I also think that opening a blank tab with no content is itself a bug. At least I did not find how to interact with it (search doesn't work on it).

Version: 2.3.1
Windows 10 Pro 22H2 (build 19045.2364)

[kelson42]

@gmikhail If you run kiwix-serve.exe —version, what is printed?

[gmikhail]

@kelson42 I don't have this file. kiwix-desktop.exe does not find this command. The installer was downloaded from the official website: https://download.kiwix.org/release/kiwix-desktop/kiwix-desktop_windows_x64.zip (redirect to https://mirrors.dotsrc.org/kiwix/release/kiwix-desktop/kiwix-desktop_windows_x64_2.3.1.zip)

[kelson42]

@gmikhail Ok, sorry might be kiwix.exe, but will check myself.

[kelson42]

@juuz0 Are you able to reproduce this issue?

[goutnet]

Hi @kelson42 I gave it a try on last main (but can't repro):

@gmikhail could you maybe provide more specific instructions to reproduce this issue?

[gmikhail]

Hi @goutnet

Latest version from the official website still has this problem (download link redirect to https://ftp.fau.de/kiwix/release/kiwix-desktop/kiwix-desktop_windows_x64_2.3.1-2.zip).

Judging by window appearance, you are using Linux, while I am using the Windows version. Maybe it's a Windows-specific Qt thing? Because arrows for switching tabs on overflow is also different.

Unfortunately, I do not currently have the opportunity to compile Kiwix from source to check if there is a bug.

Also in your screenshot you can see that you can open several empty tabs. Which in itself is also wrong behavior because an empty tab cannot be interacted with (I mentioned about this in the first message).

[goutnet]

correct, I am using Linux indeed. I don't have a Windows env running just now (will set it up later).

Regarding the empty tabs though, that one I confirm I can see it on Linux. @kelson42 is this a bug or a feature? (aka: should empty tabs be allowed?), let me know :)

[kelson42]

Empty tab clicking on + is « normal ». Feature is not fully implemented (it’s a duplicate of #499).

The problem is only the visible surnumerous vertical bar. If not buggy by us, this sounds like an upstream bug which should be reported/identified.

[kelson42]

The problem is only the visible surnumerous vertical bar. If not buggy by us, this sounds like an upstream bug which should be reported/identified.

I strongly suspect here a bug with Qt 5.13 used in the built, here (on my dev system) with Qt 5.15 I don't have the problem. We will wait to update the version Qt to see if we still have this problem. It's not important enough IMO to invest more time for the moment.

[juuz0]

@kelson42 imo this still exists (and also unnecessary thickness on top of tabs) - on latest app image.

Pretty simple fix though, just make border-right and border-top 0 for tabbar (but let me know if you can reproduce)

[kelson42]

@juuz0 what is the version of Qt you use?

[juuz0]

@kelson42 5.15 but should it matter on an appimage?

[kelson42]

I have 5.15.13 and it works fine for me. I don't know for appimage, but I'm sure there is nothing we can do anyway and that the bug is probably fixed in most recent version of Qt.