Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to turn off external link warning in associated dialogue box like Kiwix Android #295

Open
Jaifroid opened this issue Sep 27, 2022 · 3 comments
Open

Add option to turn off external link warning in associated dialogue box like Kiwix Android #295

Jaifroid opened this issue Sep 27, 2022 · 3 comments
Assignees
@Jaifroid
Labels
enhancement upstream Should be worked on in kiwix-js
Milestone
Release 3.5.0

Comments

@Jaifroid
Copy link
Member

Kiwix Android has a little link that allows a user to turn off the dialogue box that warns about external link opening (see screenshot below). We could add something similar to KJSW and/or KJS. It would be a link that takes the user to the option in Configuration and highlights it (thus educating the user), as we do with with the Active Content Warning. Is this of interest upstream, @mossroy?

image
@Jaifroid Jaifroid added this to the Release 2.2.0 milestone Sep 27, 2022
@Jaifroid Jaifroid self-assigned this Sep 27, 2022
@mossroy
Copy link

mossroy commented Sep 28, 2022

Yes, it looks like a good idea for kiwix-js as well.

@Jaifroid Jaifroid mentioned this issue Sep 29, 2022
Closed
@Jaifroid Jaifroid added the upstream Should be worked on in kiwix-js label Sep 29, 2022
@Jaifroid Jaifroid removed this from the Release 2.2.0 milestone Sep 29, 2022
@Jaifroid
Copy link
Member Author

Issue to be worked on upstream in kiwix/kiwix-js#891.

@Jaifroid
Copy link
Member Author

Jaifroid commented Mar 7, 2023 via email •
edited
Loading

@Jaifroid Jaifroid added this to the Release 2.7.0 milestone Sep 4, 2023
@Jaifroid Jaifroid modified the milestones: Release 2.7.2, Release 2.8.0 Oct 9, 2023
@Jaifroid Jaifroid modified the milestones: Release 2.8.0, Release 2.9.0 Dec 6, 2023
@Jaifroid Jaifroid modified the milestones: Release 2.9.0, Release 3.0.0 Dec 28, 2023
@Jaifroid Jaifroid modified the milestones: Release 3.0.0, Release 3.1.0 Feb 2, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.1.0, Release 3.2.0 Mar 25, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.2.0, Release 3.3.0 Apr 23, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.3.0, Release 3.4.0 May 31, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.4.0, Release 3.5.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
enhancement upstream Should be worked on in kiwix-js
Projects
None yet
Milestone
Release 3.5.0
Development

No branches or pull requests
2 participants
@mossroy @Jaifroid