-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiwix-serve should reload automatically content (library/files) #243
Comments
Another appriach might be to send a signal to the kiwix-serve which woukd then do the library reload. |
@mgautierfr @veloman-yunkan It seems we need more an more urgently this feature. We will launch a Discussing this ticket with @rgaudin it seems that we should split it in two:
So I propose to hook this reload function to the SIGHUP (1) signal. This would make this feature POSIX only but does not sound to me to be a big problem. @mgautierfr @veloman-yunkan Does that sounds right? |
@mgautierfr @veloman-yunkan A quick feedback would be much appteciated as this is on the very top of my feature list. |
We should implement #482 first. |
@veloman-yunkan Now than #482 is kind of sorted out can you please implement this ticket? |
@kelson42 This sentence is a little vague. Will you please elaborate it? What kind of changes to the content should we handle?
|
@veloman-yunkan Sorry for the late feedback but will try to answer your questions. Cases 1 - 2 - 3 - 4 - 5 If I rephrase what I have written, whatever is given to For now, our catalogue, available at https://library.kiwix.org et refreshed once a day. That means that a new So typically this will happen every 10 minutes in average, therefore this is important that this process:
|
@kelson42 Are we agree that if the couple (path/uuid) about a zim file in the xml has not changed, we can assume the file don't have to be reloaded (and if in cache, we don't need to drop it from the cache)? Other metadata may have changed and so we must update our internal library with the metadata in the xml (not reading them from zim file itself). |
Yes, I don't see any scenario why this could go wrong and this sounds importance for the overall performance of the reload. |
Though kiwix/libkiwix#636 provides bulk of the code for this enhancement, it will only be finalized when #497 is merged |
If the files open (library/ZIM files) change, then kiwix-serve should automatically detect it and reload them (or load new files and stop providing removed files). All of this should happen without service interruption. The idea here is to allow to update the library without having here to restart the whole service and create a service interruption. The reload (and not restart) should ideally be smart and do modifications in the internal library only where this is necessary.
The text was updated successfully, but these errors were encountered: